3.x disk space usage alternative #27
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of running the processes in stages like: install, build, lock... we are now introducing the concept of ProcessGroups and Batches. Each Assets will create a ProcessGroup, ProcessGroups can be worked in parallel and each Process group will have sequencial tasks. We are also adding the possibity to pass callbacks When parent and children processes start. We are reusing the existing max in parallel config to use it as max processes in parallel. We are adding the possibility to pass a callback when each batch processed befor starting the new batch. We are adding the possibility to pass callbacks when a parent or child task errored.
luislard
force-pushed
the
3.x-disk-space-usage-alternative
branch
from
3830703 to
e692784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Solves #28
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactor
What is the current behavior? (You can also link to an open issue here)
Currently the parallel manager is not really running in parallel for the installs at least.
There is no possiblity to run callbacks in important points.
There is no possibility to run a callback after a set of parallel tasks are finished.
What is the new behavior (if this is a feature change)?
Instead of running the processes in stages like: install, build, lock... we are now introducing the concept of ProcessGroups and Batches.
Each Assets will create a ProcessGroup, ProcessGroups can be worked in parallel and each Process group will have sequencial tasks.
We are also adding the possibity to pass callbacks When parent and children processes start.
We are reusing the existing max in parallel config to use it as max processes in parallel.
We are adding the possibility to pass a callback when each batch starts and finish.
We are adding the possibility to pass callbacks when a parent or child task errored.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
In the current state yes.
There is a
handleIsolatedCachemethod that was not ported in this change yetThe
wipeNodemodulesis handled a bit different we are not checking for symlink, we will need to see how this behaves.We are going to test it in one of our projects.
Other information